[Commented On] D12628: worker: fix `_blockingreader.read()` to really block

marmoute (Pierre-Yves David) phabricator at mercurial-scm.org
Fri May 20 19:14:37 UTC 2022


marmoute added a comment.


  In D12628#193398 <https://phab.mercurial-scm.org/D12628#193398>, @mharbison72 wrote:
  
  > In D12628#193397 <https://phab.mercurial-scm.org/D12628#193397>, @mjacob wrote:
  >
  >> In D12628#193391 <https://phab.mercurial-scm.org/D12628#193391>, @marmoute wrote:
  >>
  >>> Interresting. Can I convince you to send a patch adding this explanation to the class docstring ? (and maybe fixing the class name)
  >>
  >> Yes, I planned to do so. Should this go to the default branch?
  >
  > Documentation changes are OK for stable, but renames aren't, so putting everything on default is probably easiest.
  
  Yeah overall the philosophy of stable includes "restrict churn to minimum".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D12628/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D12628

To: mharbison72, #hg-reviewers, mjacob
Cc: marmoute, mjacob, mercurial-patches
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-patches/attachments/20220520/6dfb29cd/attachment-0002.html>


More information about the Mercurial-patches mailing list