[Reviewers] [PATCH 1 of 2 V2] tests: use absolute_import and print_function in seq.py , test-ancestor.py
Pierre-Yves David
pierre-yves.david at ens-lyon.org
Fri Apr 1 18:38:54 UTC 2016
On 04/01/2016 07:56 AM, Yuya Nishihara wrote:
> On Thu, 31 Mar 2016 19:15:26 +0300, Robert Stanca wrote:
>> # HG changeset patch
>> # User Robert Stanca <robert.stanca7 at gmail.com>
>> # Date 1459436991 -10800
>> # Thu Mar 31 18:09:51 2016 +0300
>> # Node ID 1aa23d597ac85bd8e53f92281a6251e58b9405d7
>> # Parent ff0d3b6b287f89594bd8d0308fe2810d2a18ea01
>> tests: use absolute_import and print_function in seq.py , test-ancestor.py
>
> I'll queue this, thanks.
>
>> - print ("%% lazy ancestor set for %s, stoprev = %s, inclusive = %s" %
>> - (revs, stoprev, inclusive))
>> + print(("%% lazy ancestor set for %s, stoprev = %s, inclusive = %s" %
>> + (revs, stoprev, inclusive)))
>> return ancestor.lazyancestors(graph.get, revs, stoprev=stoprev,
>> inclusive=inclusive)
>
> I've dropped extra parens.
>
> To committers:
> Should I split this into seq.py and test-ancestor.py patches?
We probably want to stick to the "one change per patch idea" one
category of change and one file per patch.
--
Pierre-Yves David
More information about the Reviewers
mailing list