[Reviewers] dropped a couple changesets and flushed the queue

Augie Fackler raf at durin42.com
Wed Dec 28 16:48:41 UTC 2016


> On Dec 28, 2016, at 11:17 AM, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
> 
>>> 'll make my best to put more effort into that if such situation arise.
>>> 
>>> It is probably worth to note that your ban of all communications between us outside public channels, adds a significant barrier to communicating such notice. That was part of why I skipped prior-pinging and directly moved to drop + "notification email”
>> 
>> I don’t want the “this patch might need to be dropped” discussion to be private …
> 
> [piece cut in half to clarify my answer].
> 
> I never said I wanted to full patch drop discussion in private. I'm talking about a small ping like: "I've found a regression in Mads' histedit patch, I'm about to drop it". Here is why being able to have such private ping would be useful to me:
> 
> - I would not use public IRC for that, Mads was likely to be reading the channel and such small ping was too short to make sure he would take it well. Especially given the worn-out state I saw him 48h before. I wanted his first contact to be the full explanation phrased with extra care.
> 
> - Writing that full email explanation in the thread is a process that can me around one hour. I was unsure I would have time to get it in proper state + proof-reading before going to bed, so I prioritized the unblocking of the other patches. It turned out that I got the time and energy to finalize such email while finalizing the drop. But that email might has well got proof-read and sent on the next morning.
> 
> Here is some example of discussions I could have expected around that private ping.
> 
> — marmoute: I've found a regression in Mads' histedit patch, I'm about to drop it and unblock the 92 other patches above it.
> — durin42: ha okay, thanks for letting me know, make sure to reply to the public thread.
> — marmoute: sure, will do.
> 
> Or:
> 
> — marmoute: I've found a regression in Mads' histedit patch, I'm about to drop it and unblock the 92 other patches above it.
> — durin42: Ho! I'm surprised do you have more details about that?
> — marmoute: It is mostly about phases. The shipped version of histedit rewrite secret changeset as secret. The new code promote them to draft. That's the kind of regression that will bites people. (I'm also still concerned about introducing an inconsistency with rebase but that's less concerning.)
> — durin42: okay, thanks for letting me know.

I’m still -1 on doing this anyplace other than the list. I know writing emails is a tedious process for you, but it’s the process we have and I’d rather we try and keep all the correspondence about patch series in a single place. I think its important for contributors to see the discussion too.

I know Mads was getting burned out, but I don’t know how to help that given that the patch had actual problems.




More information about the Reviewers mailing list