[Reviewers] [PATCH STABLE] log: fix order of revisions filtered by multiple OR options (issue5100)
Yuya Nishihara
yuya at tcha.org
Tue Feb 16 14:37:52 UTC 2016
On Tue, 16 Feb 2016 01:16:30 +0000, Pierre-Yves David wrote:
> [to reviewers]
> I'm planning to have a look at that
>
> On 02/15/2016 02:34 PM, Yuya Nishihara wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya at tcha.org>
> > # Date 1455543967 -32400
> > # Mon Feb 15 22:46:07 2016 +0900
> > # Branch stable
> > # Node ID ae36fdcb20ae3b7b0d8b2e7f868a1c3eb104e34e
> > # Parent 8da94662afe51a836eda500652097772c34002e8
> > log: fix order of revisions filtered by multiple OR options (issue5100)
> >
> > This is the simplest workaround for the issue of the ordering of revset, which
> > is that the expression "x or y" takes over the ordering specified by the input
> > set (or the left-hand-side expression.) For example, the following expression
> >
> > A & (x | y)
> >
> > will be evaluated as if
> >
> > (A & x) | (A & y)
> >
> > It is wrong because revset has ordering. Ideally, we should fix the revset
> > computation, but that would require a long patch series. So, for now, this
> > patch just works around the common log cases.
FYI, I have an idea that will fix the ordering issue in revset. I'm trying it.
More information about the Reviewers
mailing list