[Reviewers] Accept process and diffhashes

Augie Fackler raf at durin42.com
Fri Jun 10 16:27:06 UTC 2016


> On Jun 9, 2016, at 3:14 PM, Matt Mackall <mpm at selenic.com> wrote:
> 
> On Thu, 2016-06-09 at 14:42 -0400, Augie Fackler wrote:
>> Thanks for doing all this work, it’s helping a lot.
>> 
>> Is the review process tooling all collected in a repo someplace so I can look
>> at it and maybe review some of its implementation details?
> 
> Almost all of it is in a repo in /home/mpm/accept/.

Bug report:

Traceback (most recent call last):
  File "/home/mpm/accept/reviewed", line 9, in <module>
    a = cq.acceptors(n)
  File "/home/mpm/accept/accept.py", line 119, in acceptors
    al += [a for a in self._accepts[c] if a != self._authors.get(c) and a not in al]
KeyError: '0c6dbf7019d084d0a775dc716532b5b7f24ee7ea’

I’m not sure what the exact cause is, but it probably has something to do with the rebase that happened when Yuya fixed a patch that I pushed with a bug.


> 
> --
> Mathematics is the supreme nostalgia of our time.
> 
> _______________________________________________
> Reviewers mailing list
> Reviewers at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/reviewers

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-reviewers/attachments/20160610/78a950c9/attachment.asc>


More information about the Reviewers mailing list