[Reviewers] Heads up: new accept process is live

Augie Fackler raf at durin42.com
Sun May 15 02:39:10 UTC 2016


> On May 14, 2016, at 2:32 PM, Matt Mackall <mpm at selenic.com> wrote:
> 
> On Fri, 2016-05-13 at 13:23 -0500, Matt Mackall wrote:
>> The new accept process we discussed at the sprint is now up and running. And
>> to
>> make sure it gets tested, I'm going to focus on tooling rather than review for
>> a
>> while. So to keep patches flowing, you'll want to dig into this sooner rather
>> than later.
>> 
>> https://www.mercurial-scm.org/wiki/AcceptProcess
> 
> I've fixed a bug in the template exception for unknown nodes, you'll want to
> grab another copy.

I’m not sure if this is a bug.

augie% hg log -r 'canreview() and user(augie)'
changeset:   39438:8a66eda46c98
user:        Augie Fackler <augie at google.com>
date:        Mon May 09 21:13:50 2016 -0400
summary:     httpclient: update to upstream revision 2995635573d2

changeset:   39480:7996c3acc33b
parent:      39475:0e9ed09f5fe9
user:        Augie Fackler <augie at google.com>
date:        Thu May 12 09:39:14 2016 -0400
summary:     wireproto: optimize handling of large batch responses

I guess there are two questions:

1) Do we intend two-reviews to always be the rule, even for patches authored by a committer?
[My assumption is yes.]

2) Assuming my understanding of the new process is right, is the code smart enough that I can’t ack my own patch?
[I didn’t test this, I’m low on time tonight.]

> 
> --
> Mathematics is the supreme nostalgia of our time.
> 
> _______________________________________________
> Reviewers mailing list
> Reviewers at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/reviewers

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-reviewers/attachments/20160514/8574e221/attachment.asc>


More information about the Reviewers mailing list