[Reviewers] 5018efcbfe44 is under deeper investigation

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Nov 23 21:29:27 UTC 2016


There is a changeset from jun in the current hg-commited that concerns 
me a bit. I pointing this out on this list so that people pay a closer 
attention to it when double reviewing the pending changesets

 > 5018efcbfe44 rebase: calculate ancestors for --base separately 
(issue5420)

Details about the concerns are here.

https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-November/089931.html

On irc, Jun told me he will look into it.

17:08 < junw> marmoute: i got what you mean, i can test myself
17:08 < junw> (with drawdag, it should be easy)

Cheers,

-- 
Pierre-Yves David


More information about the Reviewers mailing list