[Reviewers] dropped a couple changesets and flushed the queue

Pierre-Yves David pierre-yves.david at ens-lyon.org
Mon Nov 28 00:32:54 UTC 2016


hello reviewers,

The queue in changeset waiting to make it to public phase was getting 
close to one hundred. I've dropped the two patch early in the stack that 
I found problematic, reviewed the score of patch that were not already 
double reviewed and flushed the result.

I tried to preserve push and acceptance history, but seems to have half 
succeeded only.

Long explanation for each drop are on the way on relevant thread. But 
here is a short version:

Jun rebase series got dropped because it the behavior in some existing 
invocation in a non-documented/unexplored way. I would like Jun to get a 
better grasp on the impact and resubmit or adapt it.

> 5018efcbfe44 rebase: calculate ancestors for --base separately (issue5420) (quark)
> 97f253e834f1 test-rebase-base: add test cases about multiple branches with merges (quark)

Mads histedit series got dropped because it change existing behavior in 
way inconsistent with rebase and potentially harmful for user relying on 
backward compatibility.

> 9375077f1ace histedit: make --keep work more like graft and use default phase for copies (madski)




For the record this was the state of the pending changeset in 
hg-commited before the operation

> 5018efcbfe44 augie 	rebase: calculate ancestors for --base separately (issue5420) (quark)
> d307cc796fed augie marmoute 	setup: add flag to build_ext to control building zstd (gregory)
> b117bacfb46f augie yuya marmoute 	perf: add command for measuring revlog chunk operations (gregory)
> 49c1a757edd6 augie yuya marmoute 	commands: print chunk type in debugrevlog (gregory)
> 9375077f1ace augie 	histedit: make --keep work more like graft and use default phase for copies (madski)
> 730fa321823a yuya augie 	shelve: move temporary commit creation to a separate function (ikostia)
> 6b0b1b2165bc yuya augie 	shelve: move commit restoration logic to a separate function (ikostia)
> ff4fd773583d yuya augie 	shelve: move rebasing logic to a separate function (ikostia)
> 2ea6bea6ff0e yuya augie 	shelve: move file-forgetting logic to a separate function (ikostia)
> 185b70710652 yuya augie 	shelve: move unshelve-finishing logic to a separate function (ikostia)
> 9246cf0c496f yuya augie 	setup: include a dummy $PATH in the custom environment used by build.py (gabor)
> 0c3a8b6239db marmoute augie 	rebase: move bookmark update to before rebase clearing (durham)
> 141b0d27e9e1 augie marmoute 	conflicts: make spacing consistent in conflict markers (ikostia)
> da2be4032691 yuya augie 	bdiff: don't check border condition in loop (gregory)
> 74131245d5ea augie yuya 	debuginstall: print compression engine support (gregory)
> de11ef807f0e augie yuya 	keepalive: reorder header precedence (gregory)
> d4bfb5c05455 augie yuya 	httppeer: do decompression inside _callstream (gregory)
> 8cd7d0fefd30 augie yuya 	httppeer: use compression engine API for decompressing responses (gregory)
> a430b93223f8 augie yuya 	wireproto: perform chunking and compression at protocol layer (API) (gregory)
> afc3f0776b74 augie yuya marmoute 	py3: use pycompat.sysargv in scmposix.systemrcpath() (7895pulkit)
> af60dfc5578d augie yuya marmoute 	py3: use pycompat.sysargv in dispatch.run() (7895pulkit)
> 9d71f4e13803 augie yuya marmoute 	py3: update test-check-py3-compat.t output (7895pulkit)
> 4f7f51a79223 augie marmoute 	windows: do not replace sys.__stdout__ (yuya)
> 591e19ae598b augie marmoute 	util: rewrite pycompat imports to make pyflakes always happy (yuya)
> 781b002f4fc7 augie marmoute 	py3: provide bytes stdin/out/err through util module (yuya)
> c736a8f2c124 augie marmoute 	py3: bulk replace sys.stdin/out/err by util's (yuya)
> 55b0a192ce24 augie marmoute 	windows: do not replace sys.stdout by winstdout (yuya)
> ce4e4035a8c1 marmoute yuya 	httppeer: drop an except block that says it happens only on Python 2.3 (augie)
> 11c0eaa1f812 marmoute yuya 	win32mbcs: drop code that was catering to Python 2.3 and earlier (augie)
> f0553ab125e8 marmoute yuya 	tests: update sitecustomize to use uuid1() instead of randrange() (augie)
> 7167679413e6 marmoute yuya 	bugzilla: stop mentioning Pythons older than 2.6 (augie)
> a4929825dd9e marmoute yuya 	archival: simplify code and drop message about Python 2.5 (augie)
> c84baff8c3d4 augie yuya 	ui: add configoverride context manager (ikostia)
> 9a4f07854ac2 augie 	bookmarks: introduce listbinbookmarks() (stash)
> 744050101c00 augie 	bookmarks: use listbinbookmarks() in listbookmarks() (stash)
> eb23353777d3 augie 	exchange: add `_getbookmarks()` function (stash)
> db897ddf3a8e augie yuya 	httppeer: document why super() isn't used (gregory)
> ed3c3eab8eaf yuya 	dispatch: stop supporting non-use of @command (augie)
> 25a57fdbcbf6 yuya 	mergemod: drop support for merge.update without a target (augie)
> a05f3fb1ea0e yuya 	keepalive: discard legacy Python support for error handling (augie)
> 6699c8148f72 yuya 	dirstateguard: move to new module so I can break some layering violations (augie)
> 67a63d7453b7 yuya 	mq: refer to dirstateguard by its new name (augie)
> a6b82643ca82 yuya 	rebase: refer to dirstateguard by its new name (augie)
> 3ad6589a9d4b yuya 	commands: refer to dirstateguard by its new name (augie)
> 10167976022f yuya 	localrepo: refer to dirstateguard by its new name (augie)
> d4d6dee77ff6 yuya 	cmdutil: mark dirstateguard as deprecated (augie)
> 7cac64596558 yuya 	checkunresolved: move to new package to help avoid import cycles (augie)
> 01fdc151fb44 yuya 	rebase: refer to checkunresolved by its new name (augie)
> bcb2c3455c10 yuya 	localrepo: refer to checkunresolved by its new name (augie)
> 01d8600955cc yuya 	cmdutil: turn forward of checkunresolved into a deprecation warning (augie)
> a08764bf0639 yuya augie 	zstd: fix compilation with Solaris Studio (danek)
> 14ddf0c8fb5c marmoute augie 	help: clarify contents of revlog index (gregory)
> c5147d5a218a augie yuya 	py3: add os.getcwdb() to have bytes path (7895pulkit)
> fdbc317b7d25 marmoute augie 	debugcommands: move 'debugbundle' in the new module (gregory)
> c9bf71132825 marmoute augie 	debugcommands: move debug{create,apply}streambundleclone to the new module (gregory)
> 6646fa67f6ff marmoute augie 	debugcommands: move 'debugcheckstate' in the new module (gregory)
> 2bcb9922ce40 marmoute augie 	debugcommands: move 'debugcommands' in the new module (gregory)
> f0a03026b18f marmoute augie 	debugcommands: move 'debugcomplete' in the new module (gregory)
> 4a29ace60cbd marmoute augie 	server: move cmdutil.service() to new module (API) (yuya)
> d3a1d14835a0 marmoute augie 	server: move service table and factory from commandserver (yuya)
> bdca223ac0fd marmoute augie 	hgweb: extract app factory (yuya)
> 4673caaad529 marmoute augie 	server: move service factory from hgweb (yuya)
> f272321e2ff3 marmoute augie 	server: add public function to select either cmdserver or hgweb (yuya)
> a4aae6edb906 marmoute augie 	chgserver: drop CHGINTERNALMARK by chgunixservice() (yuya)
> 45050fbe98cb marmoute augie 	chgserver: delay importing commands and dispatch modules (yuya)
> 7ef2ebf5cdf9 marmoute augie 	chgserver: make it a core module and drop extension flags (yuya)
> e7e4ab1a15d0 marmoute augie 	debugcommands: move 'debugdag' into the new module (gregory)
> 0f4c73d77658 marmoute augie 	debugcommands: move 'debugrevlogopts' into the new module (gregory)
> 0bb9d08ddfdb marmoute augie 	debugcommands: move 'debugdate' in the new module (gregory)
> d3df88ce7ace marmoute augie 	debugcommands: move 'debugdiscovery' in the module (gregory)
> a47eb3c53946 marmoute augie 	debugcommands: move 'debugextensions' to the new module (gregory)
> c3878fec9def yuya augie 	py3: use pycompat.getcwd() instead of os.getcwd() (7895pulkit)
> 488980533af9 yuya augie 	dispatch: move part of callcatch to scmutil (quark)
> cb88093cadca yuya augie 	worker: use os._exit for posix worker in all cases (quark)
> 290630cb4760 yuya augie 	shelve: make --keep option survive user intervention (issue5431) (ikostia)
> fd4175ec0f4e marmoute augie 	censor: flag internal documentation (remi)
> 19d286da4435 marmoute augie 	debugcommands: move 'debugfileset' in the new module (gregory)
> 0439273b27f9 marmoute augie 	debugcommands: move 'debugfsinfo' in the new module (gregory)
> 13c5030c2c00 marmoute augie 	debugcommands: move 'debuggetbundle' in the new module (gregory)
> e1f6243ac6ed marmoute augie 	debugcommands: move 'debugignore' in the new module (gregory)
> dd2ff04e91c1 marmoute augie 	debugcommands: move 'debugindex' and 'debugindexdot' in the new module (gregory)
> 906a7d8e9695 marmoute augie 	debugcommands: move 'debugdeltachain' in the new module (gregory)
> b106bb5a1dac marmoute augie 	style: avoid an unnecessary line split (denis)
> 2016feb25953 marmoute augie 	revert: indicate the default choice when prompting to forget files (denis)
> a31e207cfcae marmoute augie 	revert: prompt before removing files in interactive mode (denis)
> 9db9dc3d6223 yuya 	crecord: add an "operation" field (quark)
> 73d36d93a00b yuya 	revert: pass operation to crecord (quark)
> e69f5ad5b41b yuya 	crecord: filter text via i18n (quark)
> 60a4e8f32449 yuya 	util: limit output chunk size in zlib decompression (gregory)
> d19539606841 yuya 	ui: use try..finally in configoverride (gregory)
> 7792173cd348 yuya 	merge: use original file extension for temporary files (madski)
> 97f253e834f1 yuya 	test-rebase-base: add test cases about multiple branches with merges (quark)
> 4617b90a70ad yuya 	fsmonitor: be robust in the face of bad state (simonfar)
> 0f77caf60555 yuya 	tests: add test that @commands in debugcommands.py are sorted (gregory)
> 6c1f9bd1e65d yuya 	debugcommands: sort command order (gregory)


-- 
Pierre-Yves David


More information about the Reviewers mailing list