[Reviewers] dropped a couple changesets and flushed the queue

[Augie Fackler]

> On Nov 27, 2016, at 7:32 PM, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
> 
> Mads histedit series got dropped because it change existing behavior in way inconsistent with rebase and potentially harmful for user relying on backward compatibility.
> 
>> 9375077f1ace histedit: make --keep work more like graft and use default phase for copies (madski)
> 

It was not clear to me that there was consensus that the changes here were bad - I agree it would have been better as two patches, but other than that what am I missing that makes this worth dropping? History indicates it’ll be weeks-to-never that Mads comes back to it and it’s a clear defect fix on the whole, so I’d have liked it to be clearer on the public review thread what’s wrong here[0].

Also, as a matter of policy, I think I’d us to (in general) get an ack from another reviewer before dropping changesets from committed on the public mailing list.

Thanks!
Augie

0: While I was drafting this, your response to the review thread came in. Your concerns have merit, but I still disagree with the order in which things were done.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-reviewers/attachments/20161127/1786ec23/attachment-0002.html>