[Reviewers] [PATCH] hgweb: link to raw-file on annotation page (BC)

Pierre-Yves David pierre-yves.david at ens-lyon.org
Fri Jan 6 08:21:41 UTC 2017


On 01/04/2017 07:06 PM, Gregory Szorc wrote:
>
>> On Jan 4, 2017, at 07:37, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
>>
>>> On 12/28/2016 11:53 PM, Gregory Szorc wrote:
>>> # HG changeset patch
>>> # User Gregory Szorc <gregory.szorc at gmail.com>
>>> # Date 1482965297 25200
>>> #      Wed Dec 28 15:48:17 2016 -0700
>>> # Node ID 4a560014d6d64edcefb1d431e882824771c5ae15
>>> # Parent  dc5b594f41e9be5820ce3f197d3817379b2d3af5
>>> hgweb: link to raw-file on annotation page (BC)
>>>
>>> Every other template has the "raw" link load "raw-file." However,
>>> fileannotate.tmpl's "raw" link loads "raw-annotate." This feels
>>> inconsistent and wrong.
>>
>> Hum, yeah not being served the raw file content when clicking on raw is definitely surprising. So I'm leaning toward taking this.
>>
>> Is there another way to access the raw-annotate (beside url writing) after your change? (that page looks like a strange thing people would not use, but who can predict users in the wild).
>
> No. But it would be trivial to add if users complain. I feel this has been an accidental link for years and nobody has noticed until now. That's why I dropped the link completely.

I lean to agree here. I've pushed it with an extra ping to other 
reviewers to increase the chance of someone complaining if he disagree.

Thanks,

-- 
Pierre-Yves David


More information about the Reviewers mailing list