[Reviewers] [Differential] [Commented On] D20: check-code: prohibit `if False` antipattern

[krbullock (Kevin Bullock)]

krbullock added a comment.


  Commenting on this one also to test e-mail notifications.

INLINE COMMENTS

> check-code.py:304
>       "use True/False for constant Boolean expression"),
> +    (r'^\s*if False(:| +and)', 'Remove code instead of using `if False`'),
>      (r'(?:(?<!def)\s+|\()hasattr\(',

Cool regex bro

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D20

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: durin42, krbullock
Cc: reviewers