[Reviewers] Good video about code review etc

Augie Fackler raf at durin42.com
Wed Oct 25 22:02:10 UTC 2017


From PyCon this year: <https://youtu.be/iNG1a--SIlk <https://youtu.be/iNG1a--SIlk>>

Probably nothing earth-shattering to any of us, but it's still worth a listen at some point. He's got some good comments around 35-40 minutes about getting new contributors on board, with a graduated difficulty scale, roughly:

First time contributor -> I'll add tests, fix your code, etc.
Second time contributor -> Now the contributor gets asked to fix anything they broke, but still might add tests.
Third time -> Now you ask them to add tests, pass all existing checks, etc

We should probably try and do a little better about that as people ramp up? Thoughts? I like this particular arc, as it seems more likely to hook a new contributor.


More information about the Reviewers mailing list