[Reviewers] Good video about code review etc
Kevin Bullock
kbullock at ringworld.org
Thu Oct 26 00:22:31 UTC 2017
> On Oct 25, 2017, at 19:07, Augie Fackler <raf at durin42.com> wrote:
>
>>
>> On Oct 25, 2017, at 20:06, Kevin Bullock <kbullock at ringworld.org> wrote:
>>
>>> On Oct 25, 2017, at 17:02, Augie Fackler <raf at durin42.com> wrote:
>>>
>>> From PyCon this year: <https://youtu.be/iNG1a--SIlk <https://youtu.be/iNG1a--SIlk>>
>>>
>>> Probably nothing earth-shattering to any of us, but it's still worth a listen at some point. He's got some good comments around 35-40 minutes about getting new contributors on board, with a graduated difficulty scale, roughly:
>>>
>>> First time contributor -> I'll add tests, fix your code, etc.
>>> Second time contributor -> Now the contributor gets asked to fix anything they broke, but still might add tests.
>>> Third time -> Now you ask them to add tests, pass all existing checks, etc
>>>
>>> We should probably try and do a little better about that as people ramp up? Thoughts? I like this particular arc, as it seems more likely to hook a new contributor.
>>
>> Yeah, that seems like a pretty good ramp-up strategy. I think we still direct first-time contributors to patchbomb or Phabricator when they post somewhere else (bz) though.
>
> It might be worth taking trivial patches from bz when they're truly trivial, and give a pointer to the correct forum, as a better onramp.
Maybe. I just redirected one from hollisb (who has been active in IRC lately) that they posted to bugzilla <https://bz.mercurial-scm.org/show_bug.cgi?id=5365>.
pacem in terris / мир / शान्ति / سَلاَم / 平和
Kevin R. Bullock
More information about the Reviewers
mailing list