[Reviewers] Cultural norms & phabricator comments?

[Augie Fackler]

One of the things I've been struggling with is that it's not always clear to me when I should consider feedback addressed. With email-based patches, it's mostly unambiguous: a new patch on the list implicitly "resolves" all prior comments, and is a clean slate for acceptance.

In phabricator, though, I find myself doubting things a lot. An example of this I've tripped on today is https://phab.mercurial-scm.org/D706 <https://phab.mercurial-scm.org/D706> - where I *suspect* durham has resolved indygreg's feedback, but that's not obvious to me either. Should we have a best practice that if you think you've resolved a comment you mark it as done? I feel like that'd help me a lot, not sure about other reviewers.