[Reviewers] Recommending Phabricator

Gregory Szorc gregory.szorc at gmail.com
Sun Feb 11 22:49:19 UTC 2018


On Sat, Feb 10, 2018 at 3:03 PM, Augie Fackler <raf at durin42.com> wrote:

>
> > On Feb 9, 2018, at 12:53 PM, Ryan McElroy <rm at fb.com> wrote:
> >
> > Long ago (2012?), LLVM got a patch into the upstream for this but we
> wised up over the years and I removed it in D15850. I believe no other
> install ever used it -- at the least, no one objected when it stopped
> working, and installs stopped complaining about the feature being awful and
> ugly and started complimenting the change. I think LLVM still maintains
> some kind of patch locally, and see here for guesses about how to build
> such a patch. I can write this patch for you, but usual mana/unmainted
> caveats apply.
>
> That’s interesting. I’ll poke LLVM folks that I work with on Monday and
> see if they can point to any useful customizations they’ve done on their
> phabricator.
>
> I still find Evan’s opinion baffling, but I can at least respect that he’s
> got a vision and he’s sticking with it.


http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180205/thread.html
may serve as a useful reference.

I see some minor changes to comment formatting. e.g.
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180205/217639.html
vs
https://www.mercurial-scm.org/pipermail/mercurial-devel/2018-February/110712.html
.

I also see the list receiving "accepted" emails. e.g.
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180205/218163.html.
I /think/ we have those not going to mercurial-devel?

More importantly, they do seem to be sending threaded context as part of
emails. e.g.
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180205/217623.html.
I suspect they have a custom Phabricator plugin...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-reviewers/attachments/20180211/0cd6f764/attachment-0002.html>


More information about the Reviewers mailing list