[Reviewers] Recommending Phabricator

[Gregory Szorc]

On Sat, Feb 10, 2018 at 12:17 PM, Gregory Szorc <gregory.szorc at gmail.com>
wrote:

> On Thu, Feb 8, 2018 at 6:19 AM, Augie Fackler <raf at durin42.com> wrote:
>
>> (+Ryan since he's got a contact at Phacility)
>>
>> > On Feb 8, 2018, at 13:03, Yuya Nishihara <yuya at tcha.org> wrote:
>> >
>> > On Wed, 7 Feb 2018 09:54:39 -0800, Gregory Szorc wrote:
>> >> One of the changes I made was to recommend Phabricator over emailing
>> >> patches. I did this because I think Phabricator is more friendly to new
>> >> contributors and provides a gateway for new contributors getting more
>> >> involved.
>> >
>> > I hope not advertising Phabricator more until its email interface gets
>> fixed.
>> > Proper threading and inline-reply are must IMO.
>> >
>> >> In addition, I think the time has come for more of Mercurial's core
>> >> contributors to transition from email to Phabricator.
>> >
>> > I thought that was a temporary issue of email infrastructure at Google?
>> >
>> >> As a reviewer, I've noticed I'm biasing to looking at Phabricator first
>> >> then falling back to Patchwork if I still want to do reviews.
>> Phabricator
>> >> is just a more pleasant experience for me as both a reviewer and a
>> >> contributor.
>> >
>> > I do truly the opposite. Ignoring almost all Phabricator emails, and
>> pick
>> > random patches, which I would have to review, from Yadda using phabread.
>>
>> I still check both. I'm quicker at email reviews and find them
>> preferable, but I've also made peace with the seeming reality that new
>> contributors are significantly more comfortable with phabricator.
>>
>> I would like it if we could try and get some more improvements figured
>> out, but IIRC the email threading thing was a complete nonstarter for them?
>> Greg, do you know if Mozilla is likely to care about that?
>>
>
> Mozilla still hasn't fully rolled out Phabricator. The instance is live (
> https://phabricator.services.mozilla.com/), but no significant population
> is using it. I imagine that once we start actively using it for Firefox
> that people will start caring about things more. However, we don't
> currently do review by email. So I'm not sure how much people will care
> about email "threading."
>

https://github.com/r4nt/llvm-reviews/ is their repo with their Phabricator
config. If you follow the breadcrumbs, you see they are using a fork of
Phabricator. https://github.com/r4nt/phabricator/tree/r4nt-master appears
to be the branch that they deploy.
https://github.com/phacility/phabricator/compare/master...r4nt:r4nt-master
is the full list of changes, including lots of tweaks to email.

Jackpot!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial-reviewers/attachments/20180211/41279db8/attachment-0002.html>