My version of hgeditor script

Matt Mackall mpm at selenic.com
Thu Jul 7 07:22:25 UTC 2005


On Thu, Jul 07, 2005 at 07:00:56AM +0200, Radoslaw Szkodzinski wrote:
> 
> Features:
> * diffstat
> * faster (no useless hg diff walking)
> * always cleans up temp files
> * uses username parameter (this works with new hgrc settings)
> * other cleanups

Too much stuff all at once and not all of it is correct. For starters,
your fix for "useless diff walking" is wrong as it doesn't handle
committing less than all changed files.

Please break this up so I can examine each piece individually.

It's actually more important that hgeditor be simple than
full-featured. It's there to serve as an example of the ways you can
customize check-in, not as a full-featured commit tool. Similar logic
applies for hgeditor.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial mailing list