Patches and attachments
Matt Mackall
mpm at selenic.com
Thu Jul 28 01:58:03 UTC 2005
On Wed, Jul 27, 2005 at 06:33:43PM -0700, TK Soh wrote:
> --- Matt Mackall <mpm at selenic.com> wrote:
> > Doesn't handle non-global tmp directories. Please send one using $TMP.
> > And please don't send attachments, folks, it makes pulling your
> > patches out and applying them a royal pain. And it makes commenting on
> > them hard too.
>
> Huh!? I thought I was following the guideline - looks to me everyone was
> sending patches as attachment. You mean we should paste the patches in the
> message body?It wasn't mentioned in you earlier message on "Submitting
> patches".
Lots of people have been sending patches as attachments, yes. And it's
never been what I wanted.
I want to be able to do two things:
1) reply to the message _including the patch_ so I can comment
directly on the patch without saving it out and then pasting it into
my reply
2) pipe a message directly into a grabpatch script, which wants the
subject AND the message body AND the patch all in one plain text
stream
Inserted directly into the body of your email is best, but beware of
cut and paste and the possibly resulting line wrap and tab damage.
If you can manage to attach a patch as text/plain or something like
that, the above two will probably work. But when I get patches that
are quoted-printable or base64 or application/octet-stream and so on,
these things DON'T work.
As long as I'm on the subject, if you're using export, your commit
message should be at least as detailed as the rest of your email, and
start with a one line summary, otherwise I end up editing it.
--
Mathematics is the supreme nostalgia of our time.
More information about the Mercurial
mailing list