Some suggestions

[Radoslaw Szkodzinski]

Matt Mackall wrote:
> On Thu, Jun 30, 2005 at 12:45:00AM +0200, Radoslaw Szkodzinski wrote:
> 
>>Last try, this patch doesn't change anything at all in .hgtags reading.
>>Adds support for file .hg/hgtags for easy modification and parsing outside 
>>Python, and also adds support for local tags in hg tag, making local tag 
>>the default type of tag created.
>>
>>It was made to be as unintrusive a change as it gets.
> 
> 
> Then why does it change the default type of tag?
> 
Oops, remains from previous hack. Fixed.

> 
>>Pro .hg/hgtags:
>>- Shell scripts work better with .hgtags than ini files.
> 
> 
> Why would a shell script care? I think this might need a name like
> localtags to distinguish it.
>
The format is much easier to parse and you don't need to skip all other 
similarly looking options.
I use a shell script to see what's tagged with these private tags (they're 
used as a signpost) and not all tags from hg tags. Maybe this should be added 
to hg tags, but I can't yet think up a way to read only private or only public 
ones without some ugly hack.

In my script, I grep all local tag names and then display the commit they're 
linked to. (by grepping hg log - yes, I really need to write something like hg 
showrev, similar to hg tip)

Name change done.

> 
>>Contra:
>>- Another file in .hg - clutter?
> 
> 
> Sigh.
> 
There's no real contra as you can see.

> 
>>+                f = self.wfile(".hg/hgtags")
> 
> 
> wfile is for accessing things in the working directory. You want opener().
> 
Fixed (both places). It's weird it doesn't even warn. Maybe it should.

> We shouldn't have local tags in two places.
> 
That's why I asked # XXX: rm it? before.
IMHO .hg/localtags should be kept and hgrc tag support ripped out.
Done.

> 
>>+    "tag": (tag,  [('p', 'public', None, 'make the tag public'),
>>+                   ('t', 'text', "", 'commit text'),
> 
> 
> And public ("normal") tags should be the default.
> 
Not a problem. Done.

AstralStorm
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: hg-tag-private.diff
URL: <http://lists.mercurial-scm.org/pipermail/mercurial/attachments/20050630/04aeed3e/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.mercurial-scm.org/pipermail/mercurial/attachments/20050630/04aeed3e/attachment-0001.asc>