[PATCH 0 or 1] Fix handling non-root pattern matching in .hgignore files

TK Soh teekaysoh at yahoo.com
Mon Nov 7 08:44:53 UTC 2005



--- Benoit Boissinot <bboissin at gmail.com> wrote:

> On 11/3/05, Mitch Frazier <mitch at fmr.name> wrote:
> > Matt Mackall wrote:
> > > On Wed, Nov 02, 2005 at 08:05:18PM -0600, Mitch Frazier wrote:
> > >> The .hgignore file supports the following syntax:
> > >>
> > >>     syntax: regexp # defaults following lines to non-rooted regexps
> > >>     syntax: glob   # defaults following lines to non-rooted globs
> > >>     re:pattern     # non-rooted regular expression
> > >>     glob:pattern   # non-rooted glob
> > >>     pattern        # pattern of the current default type
> > >>
> > >> The "re:pattern" and "glob:pattern" syntaxes don't work.  This patch
> > >> fixes the problem.
> > >
> > Should be looking for "re:" or "glob:" and replacing them with "relre:"
> > and "relglob:" respectively.  Right now its looking for "relre:" and
> > relglob:".  Changing "syntaxes.values()" to "syntaxes.keys()" doesn't do
> > that, it does the match a bit better (except for the ":") but it doesn't
> > do the replace.
> 
> here is the patch that fix the issue, i didn't want to do earlier
> (when i wrote the testcase) because the fix breaks people setup (at
> least it broke mercurial .hgignore).

Slightly OT here: should the .hgignore code be kept in dirstate.py? It seems to
fit better in util.py to me. Also, I think we need an official doc for
.hgignore. Or does it already exist somewhere?


		
__________________________________ 
Yahoo! FareChase: Search multiple travel sites in one click.
http://farechase.yahoo.com



More information about the Mercurial mailing list