[PATCH] Test for $EMAIL use by commit (Fails for me.)

Thomas Arendsen Hein thomas at intevation.de
Thu Apr 20 14:37:01 UTC 2006


* Andrew Thompson <andrewkt at aktzero.com> [20060416 05:31]:
> I am pretty certain that this test would have passed a while back
> when I was working with Mercurial, but it doesn't seem to on two
> of my machines right now using tip(2060:676f5fd84a94).

see "export EMAIL" below.

> Add tests/test-env-email. This checks to see if the EMAIL environment variable is being used for commit.

Long line, I've wrapped it.

> diff -r 676f5fd84a94 -r 39387aa8bae6 tests/test-env-email
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/tests/test-env-email	Sun Apr 16 03:23:06 2006 +0000
> @@ -0,0 +1,10 @@
> +#!/bin/sh
> +unset HGUSER
> +EMAIL="My Name <myname at mydomain.com>"

You need to "export EMAIL", otherwise the environment variable
doesn't get passed to the called program (hg in this case).

And better use example.com.

> +hg commit -d '0 0' -m commit-1

hg commit -d '1000000 0'
will make broken C libraries happy.

> +date:        Thu Jan 01 00:00:00 1970 +0000

Because they would show: "Thu Jan  1" instead and so the test would
fail.

I've changed all this, and renamed the test to test-committer, so we
could add tests for option -u, $HGUSER or [ui] section, too.

Pushed to crew.

Thomas

-- 
Email: thomas at intevation.de
http://intevation.de/~thomas/



More information about the Mercurial mailing list