0.9 coming soon!

[Vadim Gelfer]

On 4/26/06, Vincent Danjean <vdanjean.ml at free.fr> wrote:

>   There are some patches that I apply in the debian package that can
> probably be applied upstream.

thank you for patches.

>   The first one is a rewrite of a patch I already proposed. I change it
> following the suggestion that have been made. The idea is to show core
> commands and extension commands in the help.
> This patch is called submitted_upstream__manage_import_extensions.patch

i like patch, but it does too many things. i will split up and apply pieces.

>   I also see that "hg bisect help" does not work outside a repo.

>   The second one allows to pull from an empty repo without getting a
> backtrace. Without this patch, try:
> mkdir a; cd a; hg init; cd ..; hg clone a b; cd b; hg pull ../a
> This patch is called submitted_upstream__null_repo_pull.patch

pushed to crew. thank you.

> submitted_upstream__hash_keys.patch is needed because using a non
> existant key in a hash return an error instead of a 'false' value.

this is bug in tailor. tailor should be passing dict with empty string
as value here. so patch not applied, sorry.

> submitted_upstream__dirstate_is_not_in_unicode.patch is needed because
> without it (ie when using a '+' operator on the string) a Unicode
> exception occurs (ie the string is not a valid unicode one). I do not
> know how to tell python that these string (e and f) are binary strings
> and not unicode strings.

sorry. i do not understand why unicode exception is thrown here. that
code should not see any unicode strings, so if you can see how unicode
string gets in there, that will be big help. this looks like tailor
bug too.

>   When tailor directly calls hg.pull(...), it gets the exception and
> die. Would not it be better if the exception were caught in the
> hg.pull() method instead of commands.dispatch / transaction.py ?

exception is not raised with your patch and current hg. so i see no problem.