[PATCH 0 of 2] mq: modify lookup to resolve mq patches, 'qtip' and 'qbase'
Brendan Cully
brendan at kublai.com
Tue Jul 25 21:54:10 UTC 2006
On Friday, 21 July 2006 at 11:18, Alexis S. L. Carvalho wrote:
> Thus spake Brendan Cully:
> > When mq is loaded, it will patch repo.lookup to search for applied mq
> > patches if regular lookup fails. The second patch resolves the
> > symbolic names 'qtip' and 'qbase' as well.
>
> If you just change repo.lookup, these extra tags won't appear in the
> output of hg tags nor hg log, etc., making them a bit confusing and a
> bit different from regular tags and local tags.
>
> Maybe it'd be better to add a tagfunctions list to localrepository and
> have mq append a function to this list? Then repo.tags could call each
> function in the list to get the additional tags. The function would
> take the repo as an argument and would either return a dict with the
> tag->node mapping or yield (tag, node) tuples.
it's easy enough to override repo.tags to add new mq tags. I think
this might make sense for qbase and qtip. Should all of the patches go
there though?
> Depending on where in repo.tags you call these functions, you can even
> make them able to override regular tags.
I don't really like the fact that tags and patches could have the same
names. Anyone have any thoughts on what the right policy would be
here?
More information about the Mercurial
mailing list