mercurial/crew: 94 outgoing changesets

Matt Mackall mpm at selenic.com
Mon Mar 20 15:09:45 UTC 2006


On Mon, Mar 20, 2006 at 01:00:10PM +0100, Mercurial Commits wrote:
> 94 outgoing changesets in mercurial/crew:
> 
> http://hg.intevation.org/mercurial/crew?cs=10606ee61107
> changeset:   1978:10606ee61107
> tag:         tip
> user:        TK Soh <teekaysoh at yahoo.com>
> date:        Mon Mar 20 08:46:29 2006 +0100
> summary:     do proper typecasting on malloc() and calloc() calls

This patch is wrong. 

Both malloc and calloc are defined to return void *, which is
automatically cast to the appropriate type. So all this patch does is
uglify the code. I have no idea why people think this sort of
redundant cast is a good idea.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial mailing list