hg diff: why is it listing the directories?

[Giovanni Bajo]

On 02/06/2007 20.11, Guido Ostkamp wrote:

>>> Now, why is necessary the list the contents of the directories, for 
>>> hg diff? Doesn't hg have all the required metadata to know which 
>>> files to stat without listing anything?
>>
>> Known bug.
>>
>> Workaround: make sure all files that aren't part of your project are 
>> properly ignored.
> 
> this is most likely the 'lstat' bug. I've documented it two weeks ago at 
> <http://www.selenic.com/mercurial/bts/issue567>.
> 
> I'm waiting for Alexis (who requested a verification which I provided) 
> to fix the issue. The version which introduced the bug is already known.

I still can't see why *any* getdent call is required for "hg diff". It looks 
like this bug is about a regression where a full useless dirwalk is performed, 
but even in the "fixed" version (b4eaa68dea1b), there are still 2 getdent calls.
-- 
Giovanni Bajo