[PATCH] convert-repo: --ignore and --usermap for CVS
Dirkjan Ochtman
dirkjan at ochtman.nl
Fri May 18 20:51:35 UTC 2007
Matt Mackall wrote:
>> If the changes have something stupid in them, it's because I'm not a
>> real Python programmer.
>
> Your Python looks fine, except for inconsistent indent levels.
Well, this could be written differently (and more readable, IMHO):
>> - if opts.get('usermap'):
>> + if 'usermap' in opts:
(And the same thing for 'ignore', of course.)
Regards,
Dirkjan
More information about the Mercurial
mailing list