Bug: web review diff not aware of hg rename

Martin Geisler mg at daimi.au.dk
Mon Dec 29 12:18:50 UTC 2008


Weijun Wang <Weijun.Wang at Sun.COM> writes:

>>> --- /dev/null
>>> +++ b/resp
>> 
>> And this is a standard diff accepted by most patch tools.
>> 
>
> I see. But, this format is quite unfriendly. I'm now working on a bug
> which rename a file and do some editing inside it. If the web view
> goes the git style, my code reviewer will be very happy.

If I set "git = 1" in my .hgrc file and do a "hg serve" on a repository
with a renamed file, then I see a nice git-style rename in the web
interface. So you should make sure that user executing the web interface
has the "git = 1" option set.

Also, Issue1258 is about this and its fix was included in Mercurial 1.1:

  http://www.selenic.com/mercurial/bts/issue1258

So you'll want to update Mercurial if you haven't already done so.

> In fact, I'm using the gitweb style, shouldn't it automatically use
> the git diff format?

The gitweb style is just named like that because it was originally based
on the default theme for Git's web frontend.

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.mercurial-scm.org/pipermail/mercurial/attachments/20081229/2e026d08/attachment-0001.asc>


More information about the Mercurial mailing list