Upgrade from 1.5 to 1.6.2 question

[Matt Mackall]

On Tue, 2010-08-17 at 21:29 -0700, Waldemar wrote:
> On 08/17/2010 06:54 AM, Matt Mackall wrote:
> > On Tue, 2010-08-17 at 20:37 +0800, TK Soh wrote:
> >   
> >> On Tue, Aug 17, 2010 at 2:32 PM, Dirkjan Ochtman <dirkjan at ochtman.nl> wrote:
> >>     
> >>> On Tue, Aug 17, 2010 at 06:40, Waldemar <waldemar at beechwoods.com> wrote:
> >>>       
> >>>> Looks like $? returns non-zero after the "gee, your files are really
> >>>> big"  warning/comment (I am paraphrasing).  It used to be 0.
> >>>>         
> >>> Not sure that's a good change...
> >>>       
> >> I feel a warning/comment should not return non-zero value.
> >>     
> > Fortunately, the claim is incorrect both by testing and code inspection:
> >
> > $ hg add a ; echo $?
> > a: up to 47 MB of RAM may be required to manage this file
> > (use 'hg revert a' to cancel the pending addition)
> > 0
> >
> > The add command will only give a non-zero return if it fails to add
> > explicitly specified files, behavior that's been there since at least
> > 1.0.
> >
> >   
> Given this evidence, I retraced my steps and paid particular attention
> to what I was doing and what the fix was. First of all, I misstated the
> case where the change occurred.  It is not when checking-in large files
> but it is when checking in identical files, i.e. no change at all (there
> is a check for large files warnings near the fix which led to the
> confusion).  This case returns 0 in version 1.5.4, as well as in version
> 1.4.2.  It returns 1 in version 1.6. 
> 
>     hg st        -- make sure nothing will check-in
>     hg ci -m comment -A
>     echo $?

That'd be a bug fix. Failure to commit -> non-zero exit code.

-- 
Mathematics is the supreme nostalgia of our time.