[ANN] hg-review extension

[Steve Losh]

On Jul 13, 2010, at 10:16 AM, Didly wrote:

> On Tue, Jul 13, 2010 at 2:21 PM, Steve Losh <steve at stevelosh.com> wrote:
> I've been working on hg-review for quite a while now and it's finally matured to the point where I'm ready to get some real-world feedback before I make an official "1.0.0" release.
> 
> code: http://bitbucket.org/sjl/hg-review/
> docs: http://sjl.bitbucket.org/hg-review/redd
> 
> Wow, this is really impressive Steve!
> 
> I just gave it a quick try using your example repository and I have the following comments (note that I tested this on Firefox 3.6.6 on Windows):
> 
> - There does not seem to be a way to edit comments. Your "release notes" on your previous email seem to indicate that this should be supported, but I did not find a way to do it.

It's because the server is in "read-only" mode. If you run it locally without that flag you should be able to edit comments (and signoffs).

> 
> - When you click comment it seems to reload the page and you lose your scroll position within the page. If the changeset is very long it could get annoying to have to find your way back to the line that you were commenting every time that you add a new comment.

Yeah, making this an AJAJ request instead of reloading the page is on my todo list.

> 
> - The button that let's you add a comment to the file says "Add a comment on this file". I think that this is a bit unclear. Does it mean that the button let's you "Add a comment on the changes made to this file"?

hg-review supports three kinds of comments:

* Comments on a changeset as a whole.
* Comments on a file as a whole.
* Comments on specific lines of a specific file.

The button will add a comment to the file as a whole.

> 
> - The web pages do not cope well with Firefox' "full page zoom". The page grows greater than the firefox window and horizontal scrollbars appear. It would be much better (IMHO) if the main lateral panel kept its size and position while the text, buttons, etc. increased its size.

"Full page zoom" means (I think): zoom *everything* on the page -- not just text.  This includes images, divs, etc.  It's the intended behavior of Firefox.

> 
> Also, is this "compatible" with running the builtin hg web server?

Not sure what you mean.  If you mean "does running this server let you pull from the repo" then no, it's just an interface to the review data.

> 
> 
> Overall this is very impressive and awesome work! I may try to run it in my windows machine. If I do so I will tell you if it works.
> 
> Angel
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial/attachments/20100714/c9a71716/attachment.html>