Problems with pretxnchangegroup hook

Douglas Simon doug.simon at oracle.com
Fri Jun 25 10:47:36 UTC 2010


On Jun 25, 2010, at 12:33 AM, Matt Mackall wrote:

> On Wed, 2010-06-23 at 17:47 +0200, Douglas Simon wrote:
>> The documentation for 'pretxnchangegroup' at http://hgbook.red-bean.com/read/handling-repository-events-with-hooks.html#sec:hook:pretxnchangegroup includes the following:
>> 
>>   "...if other Mercurial processes access this repository, they will be able to see the almost-added changesets as if they are permanent."

<snip>

>> 
> 
> After this fix, transactions in progress are only visible to Mercurial
> commands in the hook's subshell (which have the magic HG_PREPEND flag in
> the environment). This means, for instance, someone can't accidentally
> start pulling transactions that aren't completed and might get rolled
> back in the middle of the pull.

Ok, definitely sounds like an improvement. I guess the HG book will
reflect this change at some point. I left a comment one the online
book site to suggest this.

-Doug


More information about the Mercurial mailing list