util.abort typo fixes

Martin Geisler mg at lazybytes.net
Thu Nov 11 06:28:47 UTC 2010


richhguard-temp at yahoo.co.uk writes:

> Hi,
> I got an exception when using the gpg extension and entering the wrong password.
>  
> Here is a patch which fixes the util.abort typo's - one change in gpg.py, and another in commands.py.
>  
> Thanks for Mercurial - it helps me so much.
> Richard
>
> # HG changeset patch
> # User Richard Hopkins
> # Date 1289334356 0
> # Node ID a1fe9c79beb5c907fb36b830e72d90c802a2e9e1
> # Parent  7a2bca0b1e70cccf0edf0a15dcf45088551daeb3
> Fixed util.abort to util.Abort typo.

Nicely spotted -- and great job looking through the rest of the code for
this. I have pushed the change on the stable branch (0d4fb319974b) so
that it will be part of the 1.7.1 release.

Greg is right that it would be good to have tests for this so that we
make sure to get into all corners of the code. Alternatively you could
add a new pattern to contrib/check-code.py -- that is our little code
checked that looks for bad/wrong patterns in the code.

I pushed the fix now to get that out the door -- we can then push a
followup changeset later with tests.

-- 
Martin Geisler

Mercurial links: http://mercurial.ch/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.mercurial-scm.org/pipermail/mercurial/attachments/20101111/8080a9cf/attachment.asc>


More information about the Mercurial mailing list