Largefiles slow with ignored files?

Michał Sznajder michalsznajder at gmail.com
Sat Apr 7 18:36:55 UTC 2012


> I checked the code and I think it has something to do with a comment here
> http://selenic.com/repo/hg/file/329887a7074c/hgext/largefiles/reposetup.py#l158
> Why ignored files are so special that we always request for them?
> They are only used in line 242 to calculate unknown files.

Actually I tried patch below and to my surprise largefiles tests are still green

  $ python run-tests.py test-largefiles*
  ...
  # Ran 3 tests, 0 skipped, 0 failed.

I will send a full patch unless someone has a explanation for me why ignored
files are so special for largefiles status operation.

--- a/hgext/largefiles/reposetup.py
+++ b/hgext/largefiles/reposetup.py
@@ -158,7 +159,7 @@
                 # Get ignored files here even if we weren't asked for them; we
                 # must use the result here for filtering later
                 result = super(lfilesrepo, self).status(node1, node2, m,
-                    True, clean, unknown, listsubrepos)
+                    listignored, clean, unknown, listsubrepos)
                 if working:
                     try:
                         # Any non-largefiles that were explicitly
listed must be

Michał Sznajder



More information about the Mercurial mailing list