Mercurial is bad for community code reviews

[Arne Babenhauserheide]

Am Dienstag, 18. Dezember 2012, 14:47:37 schrieb anatoly techtonik:
> GnuPG requirement is too strict for an open source project, and this still
> pollutes the history requiring one more changeset per review. 

I would not call that pollution. It is the proof of the review. And the only 
way to make a secure review without rewriting what you review is adding a 
commit.

(if you change the revision your review, users of your changeset cannot know 
anymore what part of it was actually contributed, so you destroy information)

To have a clean log, you can just filter out the signatures. Or use a tool 
which does not show the signature changesets, but annotates the revisions 
instead.

But if GnuPG is too much of a requirement, it might be useful to add a „sign 
off insecurely“-extension.

If you are willing to rewrite history, though, you can just add reviewer-
information to the commit message (or, if you want to write an extension, just 
use the extra-field for that).

> How to record changesets done by several people? 

You can just add them all as author (-u "Author 1, Author 2, …").

> How to make onsite merges with reviewer names on BitBucket? 

That is an issue of Bitbucket, which is a separate service.

Normally you just pull to your computer, review, merge, then push.

> There should be a native version control support for
> distributed reviews.

Are there more features you’d like to have than the ones you already asked 
about?

Best wishes,
Arne
--
A man in the streets faces a knife.
Two policemen are there it once. They raise a sign:

    “Illegal Scene! Noone may watch this!”

The man gets robbed and stabbed and bleeds to death.
The police had to hold the sign.

…Welcome to Europe, citizen. Censorship is beautiful.

   ( http://draketo.de/stichwort/censorship )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 316 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.mercurial-scm.org/pipermail/mercurial/attachments/20121218/1ac38a94/attachment.asc>