Possible issue with command server

[Idan Kamara]

On Sun, Apr 13, 2014 at 7:01 AM, Yuya Nishihara <yuya at tcha.org> wrote:

> On Sat, 12 Apr 2014 16:53:18 -0400, Matt Mackall wrote:
> > On Sat, 2014-04-12 at 20:37 +0200, Detlev Offenbach wrote:
> > > I am attaching my IDE (eric5) to Mercurial using the command server.
> That
> > > works quite well. However, in a particular case it fails. This is when
> Mercurial
> > > is asking the user for login credentials (e.g. when pushing to a
> repository
> > > that needs this). First the user name is requested and I can send the
> data
> > > fine through the 'L' channel. Thereafter the prompt 'password: ' is
> send
> > > through the 'e' channel but there is no input request through the 'I'
> or 'L'
> > > channel. How am I supposed to handle this case and send the password
> > > back to the server?
> >
> > Probably an oversight in our command server. We're probably still
> > calling the stock get-password-safely-from-console code rather than
> > going through the command server channel.
> >
> > Please file a bug report so we can keep track of this and you can stay
> > in the loop: http://bz.selenic.com
>
> It's reported as
> http://bz.selenic.com/show_bug.cgi?id=3161
>
> FYI, I wrote a little extension for TortoiseHg to capture ui labels and
> progress.
>
>
> https://bitbucket.org/tortoisehg/thg/src/a859f999ce68/tortoisehg/util/pipeui.py#cl-222


Looks like you're solving a couple of issues with the protocol there,
any reason you haven't submitted those? We can at least do something
about getpass.

Changing the message format in the manner that you have is probably
not going to work for existing clients but we could perhaps add another
channel for labels?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial/attachments/20140413/9d114693/attachment-0002.html>