Possible issue with command server

[Yuya Nishihara]

On Sun, 13 Apr 2014 13:07:36 +0300, Idan Kamara wrote:
> On Sun, Apr 13, 2014 at 7:01 AM, Yuya Nishihara <yuya at tcha.org> wrote:
> > On Sat, 12 Apr 2014 16:53:18 -0400, Matt Mackall wrote:
> > It's reported as
> > http://bz.selenic.com/show_bug.cgi?id=3161
> >
> > FYI, I wrote a little extension for TortoiseHg to capture ui labels and
> > progress.
> >
> > https://bitbucket.org/tortoisehg/thg/src/a859f999ce68/tortoisehg/util/pipeui.py#cl-222
> 
> Looks like you're solving a couple of issues with the protocol there,
> any reason you haven't submitted those? We can at least do something
> about getpass.

Ok, I'll try to fix ui.getpass(), probably by using isatty(fin) ?

> Changing the message format in the manner that you have is probably
> not going to work for existing clients but we could perhaps add another
> channel for labels?

It won't be easy because arguments of ui.write() can be pre-labeled:

    msg = ui.label('foo', 'status.added')
    ui.write(msg)

And if I understand it, commandserver avoids extending ui class.

Regards,