Another command server issue

[Matt Mackall]

On Thu, 2014-04-17 at 18:51 +0200, Detlev Offenbach wrote:
> Hello,
> 
> today I encountered another command server issue. The issue happened only on 
> Windows systems.
> 
> My software is using the command server. For the log command I am using a custom 
> template. In the history there is a changeset, that has lots of modified files. When retrieving 
> all history data the output is fairly big, i.e greater than 4096 bytes. This causes the 
> command server to send just the first 4092 bytes of data and than waiting for some input 
> via the L channel. In other such situations my IDE simply crashes, probably due to trying 
> to read more data than was sent.

This seems.. improbable.

For starters, there is no logic on the Mercurial side to limit the size
of outgoing chunks to 4k (or any size at all). It is happy to send
gigabyte-sized chunks and will do so when you ask it to cat a big file
(which is why it uses a 32-bit size field). It's the receiver's job to
buffer that appropriately.

Secondly, there's no reason the log command would prompt for input.

-- 
Mathematics is the supreme nostalgia of our time.