[PATCH] BUG 3692

[Giovanni Gherdovich]

On Sun, Feb 9, 2014 at 1:40 PM, Anurag Goel <anurag.dsps at gmail.com> wrote:
>
> # HG changeset patch
> # User anuraggoel <anurag.dsps at gmail.com>
> # Date 1391949508 -19800
> #      Sun Feb 09 18:08:28 2014 +0530
> # Node ID 83cfdf90d5bf7ddd79ac3c409b4b21e3e0339db0
> # Parent  85d9196dc8e2adefff9e6104ee72a70dece25a78
> BUG 3692

Not a very good start.

On IRC you have been invited multiple times
to read the page http://mercurial.selenic.com/wiki/ContributingChanges ,
yet your patch is

* containing a bad description
http://mercurial.selenic.com/wiki/ContributingChanges#Patch_descriptions
* sent to the wrong mailing list
http://mercurial.selenic.com/wiki/ContributingChanges#Emailing_patches

All in all, your submission fails in satisfying
many items of the "Submission Checklist", which apparently
you didn't bother to read.
http://mercurial.selenic.com/wiki/ContributingChanges#Submission_checklist

Please read that page attentively.

Cheers,
GGhh


>
> diff -r 85d9196dc8e2 -r 83cfdf90d5bf bug_3692.patch
> --- /dev/null   Thu Jan 01 00:00:00 1970 +0000
> +++ b/bug_3692.patch    Sun Feb 09 18:08:28 2014 +0530
> @@ -0,0 +1,18 @@
> +--- /home/anuraggoel/src/crew/mercurial/commands.py    2014-02-09
17:22:08.551116294 +0530
> ++++ /home/anuraggoel/mercurial/crew/mercurial/commands.py
 2014-02-08 00:39:50.501042567 +0530
> +@@ -4707,14 +4707,7 @@
> +                 # this lets simultaneous -r, -b options continue working
> +                 opts.setdefault('rev', []).append("null")
> +
> +-    if not dest:
> +-        dest=ui.expandpath('default-push','default')
> +-        if dest != 'default-push':
> +-            ui.status(_('Your default push location is %s\n') %
util.hidepassword(dest))
> +-            ui.status('choose option to continue pushing [y/n]\n')
> +-            choice=raw_input()
> +-            if choice == 'n':
> +-                return
> ++    dest = ui.expandpath(dest or 'default-push', dest or 'default')
> +     dest, branches = hg.parseurl(dest, opts.get('branch'))
> +     ui.status(_('pushing to %s\n') % util.hidepassword(dest))
> +     revs, checkout = hg.addbranchrevs(repo, repo, branches,
opts.get('rev'))
> _______________________________________________
> Mercurial mailing list
> Mercurial at selenic.com
> http://selenic.com/mailman/listinfo/mercurial
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial/attachments/20140209/891f3cc4/attachment-0002.html>