contribution process

[Gregory Szorc]

On 7/4/14, 3:34 AM, Roman Neuhauser wrote:
> # raf at durin42.com / 2014-07-02 16:18:29 -0400:
>> On Jul 2, 2014, at 4:06 PM, cowwoc <cowwoc at bbs.darktech.org> wrote:
>>> I understand that Augie and mpm have issues with PRs but I see no
>>> reason why we couldn't get the PR system to cater to their needs
>>> (using webhooks as Paul said). Let's make this happen.
>>
>> If you've got time to spend on this, I'd be delighted! I'd even try
>> and integrate it into the patch robot.
>
> sorry to piggyback on your email, this is not directly related to
> your comment...
>
> i saw diffscuss on hackernews the other day, is that interesting?
>
> https://news.ycombinator.com/item?id=7973832
> https://github.com/hut8labs/diffscuss
>
> What is Diffscuss?
>
>    * a file format, built on the the unified diff format, that allows
>      threaded code reviews to exist inline with the diffs they address
>
>    * an Emacs mode and Vim plugin to support responding to / managing
>      code reviews in that format (including jumping directly to the
>      source code a comment addresses--great for actually making those
>      little fixes and improvements)
>
>    * a set of command line tools to support generating and managing
>      reviews in the diffscuss format with a simple, directory based tool
>      for posting and managing code reviews, as well as to import reviews
>      from github pull requests (experimental)
>

Very interesting. I was planning on attempting something like this in 
Mozilla's ReviewBoard extension. Essentially, `hg mergereview` would 
pull down review comments for the active changeset from ReviewBoard and 
then "merge" these into local files - similar to how conflict markers 
work on merges. The files with review comments would be marked 
appropriately so that they would require an `hg resolve -m` before a 
commit could occur. I haven't got to that phase of implementation yet. 
Looking at diffscuss, I'm tempted to make ReviewBoard output diffscuss 
diffs and teach Mercurial how to apply them. We'll see. Don't expect 
anything from me for a month or two.