deprecated --style

[anatoly techtonik]

On Fri, Jul 25, 2014 at 5:02 PM, Matt Mackall <mpm at selenic.com> wrote:
> On Sun, 2014-07-20 at 14:20 +0300, anatoly techtonik wrote:
>> On Sun, Jul 20, 2014 at 1:59 PM, Yuya Nishihara <yuya at tcha.org> wrote:
>> > On Sun, 20 Jul 2014 13:49:07 +0300, anatoly techtonik wrote:
>> >> I could find --style in `hg log -h` output, and found out
>> >> that it is deprecated.
>> >>
>> >>     templateopts = [
>> >>         ('', 'style', '',
>> >>          _('display using template map file (DEPRECATED)'), _('STYLE')),
>> >>         ('T', 'template', '',
>> >>          _('display with template'), _('TEMPLATE')),
>> >>     ]
>> >>
>> >> How come? Why? It is convenient to have a couple of popular formats.
>> >
>> > --style style is superseded by -Tstyle.
>> >
>> > http://selenic.com/repo/hg/rev/3a35ba2681ec
>> > http://selenic.com/repo/hg/rev/870d60294b04
>>
>> >hg log --style short
>> abort: style 'short' not found
>> (available styles: bisect, changelog, compact, default, phases, xml)
>>
>> >hg log -T short
>> shortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshor
>> shortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshor
>> shortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshortshor
>> shortshortshortshortshortshortshortshortshortshortshortshortshort
>
> Looks legit.
>
> I folded all the features of the --style and --template options (plus
> some new ones) into -T. But I accidentally left this one out: there were
> no invalid inputs to the old --template, so there are no invalid inputs
> to the new -T. So we need to pick a reserved word (like "list") and come
> up with a new error message.
>
> Of course, you can still do hg log --style list: deprecated features
> don't go away.

These feature became an inherently tough stuff to discover. I'd like to
see improved help message. Like "(try also -T help)".
-- 
anatoly t.