Update fails with long file name

[Benjamin Fritz]

On Tue, Sep 29, 2015 at 4:06 PM, Aaron Cohen <aaron at assonance.org> wrote:
>
> For the record, regarding the file named "aux" issue.
>
> 1) When you hg add a reserved file name such as "aux"
>
> > echo "test" > aux
> > hg add aux
> warning: filename contains 'aux', which is reserved on Windows: 'aux'
>
> 2) If you clone or pull from this repo, on Windows you get an abort, with
or without my extension:
> > hg clone test.bundle test
> requesting all changes
> adding changesets
> adding manifests
> adding file changes
> added 1 changesets with 1 changes to 1 files
> updating to branch default
> abort: filename contains 'aux', which is reserved on Windows: 'aux'
>

That was my next test, because I was curious whether your plugin could work
around both issues. I got as far as step 1. On Windows that warning is
replaced with "abort" instead, with or without the plugin. But at least
there is a meaningful error message for trying to add reserved file names.
That's good!

I think the error given for long file names could be much better. When I
test adding such a file I just get "{filename} does not exist!" That's not
very nice. Better would be "File name '{filename}' is too long for
Windows"; even nicer on Windows would be to distribute the win32lfn plugin
and give a helpful pointer to it in this situation. I'm not sure how hard
that would be or whether there is any precedent in Mercurial; I'm mostly
thinking of times I've tried to run a command in Ubuntu and have been
pointed at the package that would give me that missing command.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurial-scm.org/pipermail/mercurial/attachments/20150929/a4aee927/attachment-0002.html>