Socket timeout

[Cédric Krier]

On 2018-10-03 12:40, Augie Fackler wrote:
> > On Oct 3, 2018, at 12:38, Cédric Krier <cedric.krier at b2ck.com> wrote:
> > 
> > On 2018-10-03 11:52, Augie Fackler wrote:
> >>> On Sep 29, 2018, at 05:32, Cédric Krier <cedric.krier at b2ck.com> wrote:
> >>> On 2018-09-24 08:42, Augie Fackler wrote:
> >>>> Greg, have you observed anyplace we could configure some global timeouts like this user is requesting? It sounds reasonable to me...
> >>> 
> >>> I made some test and indeed there is no timeout when using HTTP
> >>> protocol.
> >>> As far as I can see, HTTP connections are made with the standard library
> >>> httplib.HTTPConnection [1]. If no timeout is given which seems to be the
> >>> case, the global default timeout is used [2] and it is None by default.
> >>> So I think it will be good to have a configuration to set the default
> >>> timeout in dispatch.py. If you agree on this, I can work on a patch.
> >> 
> >> I might be inclined to do this as a context manager in httppeer or some lower layer, so we can restore it when done, just to avoid as many surprises as possible.
> > 
> > Does you mean something like this:
> > 
> 
> Sure! send that as a patch to mercurial-devel@ or use phabricator?

Here is: https://phab.mercurial-scm.org/D4878

-- 
Cédric Krier - B2CK SPRL
Email/Jabber: cedric.krier at b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 376 bytes
Desc: not available
URL: <http://lists.mercurial-scm.org/pipermail/mercurial/attachments/20181004/4ed4f05e/attachment.asc>