problem with hidden (amend commit) and a hook

[Matt Harbison]

On Thu, 30 Aug 2018 11:25:05 -0400, Uwe Brauer <oub at mat.ucm.es> wrote:

> Hi
>
> I just pushed and received the following hg push
> pushing to https://kalthad@bitbucket.org/kalthad/contflowmap
> searching for changes
>  ChangeLog                      |    24 ++-
>  20 files changed, 2647 insertions(+), 1038 deletions(-)
> error: outgoing.notify hook raised an exception: hidden revision '317'
> (run with --traceback for stack trace)
>
> But it seemed that the push went ok, when I rerun
>
>  hg push --traceback
>
> As recommended I obtained: no changes found.
>
> Is this serious? How can I avoid that message?

It looks like a bug in the notify extension.  Any hooks supposed to run  
afterward didn't, and probably nobody was notified.

I think what happened here is the hook failed, but it's not the type of  
hook where the transaction is rolled back.  It's purely a post-op  
notification.  Therefore, the push worked and there's nothing more to push  
the second time.

> I have
> [hooks]
> outgoing=hg diff --stat -r "p1($HG_NODE)" -r "max(descendants($HG_NODE))"
>
> And locally
> outgoing.notify = python:hgext.notify.hook
>
> Running on Ubuntu 16.06: mercurial  4.4.1  (which is not the  official
> ubuntu mercurial version)
>
> _______________________________________________
> Mercurial mailing list
> Mercurial at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial