hg experimental (facebook)

Uwe Brauer oub at mat.ucm.es
Wed Jan 22 18:37:15 UTC 2020


   > Hi Uwe,
   > On Mon, Jan 13, 2020 at 7:26 PM Pulkit Goyal <7895pulkit at gmail.com> wrote:

   > I spent some time last week to port extension to core mercurial. I
   > sent a patch[1]. Even if that does not get merged, you can copy that
   > code and use that as an extension.

   > [1]: https://phab.mercurial-scm.org/D7932

Ok I confess you couln't wait for you answer, so I boldly applied your
patch to changeset 43305:d782cce137fd from the default branch.
Recompiled and reinstalled, 

And it works, really great.

Just one small observation

In a repository with some stripped changeset I obtain
,----
| 
| 
| hg debugbackups
| Recover changesets using: hg debugbackups --recover <changeset hash>
| 
| Available backup changesets:
| Wed 09:33, 2020-01-22
| d31c0dffa450 Update exam: support for environments like checkboxes, choices etc
| 
| Wed 09:12, 2020-01-22
| ab4244c3c54a Merged exam into master
| 6678d5f761d8 Merge algpseudocode into master
| 96b90b89a81d Merge algorit into master
| 
| Tue 12:38, 2020-01-21
| 55804f5af22a Update exam: support for checkboxes, choices etc
| 
| Sat 09:48, 2020-01-04
| 66393ed70a1e Create Uwe branch (successor of algpseudo) merge algorithm in.
| 
| Fri 10:09, 2020-01-03
| 1ed760de5600 Add support for the algorithm style
`----

Which is perfectly fine!

However in a repository with nothing stripped I obtain 

,----
| hg debugbackups
| Recover changesets using: hg debugbackups --recover <changeset hash>
| 
| Available backup changesets:oub at Utnapischtim:~/ALLES/src/hg-stable 
`----

So adding a newline after the message 
Available backup changesets:

Would be helpful and would enhance the readability. 

Thanks again for this cool patch.

Definitely with or without my suggestion it should go into core!

Uwe 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5673 bytes
Desc: not available
URL: <http://lists.mercurial-scm.org/pipermail/mercurial/attachments/20200122/c9d2122d/attachment.p7s>


More information about the Mercurial mailing list